Skip to content

[Trend Micro Vision One] Initial Release for the Trend Micro Vision One Package#3963

Merged
andrewkroh merged 6 commits intoelastic:mainfrom
vinit-chauhan:package_trend_micro_vision_one
Oct 4, 2022
Merged

[Trend Micro Vision One] Initial Release for the Trend Micro Vision One Package#3963
andrewkroh merged 6 commits intoelastic:mainfrom
vinit-chauhan:package_trend_micro_vision_one

Conversation

@vinit-chauhan
Copy link
Contributor

@vinit-chauhan vinit-chauhan commented Aug 5, 2022 •
edited
Loading

What does this PR do?

  • Generated the skeleton of the Trend Micro Vision One integration package.
  • Added a data stream.
  • Added data collection logic to the data stream.
  • Added the ingest pipeline for the data stream.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files
  • Added dashboards and visualizations.
  • Added test for pipeline for the data stream.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^8.4.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/trend_micro_vision_one directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image
image
image
image
image
image

@vinit-chauhan vinit-chauhan added enhancement New feature or request Team:Security-External Integrations New Integration Issue or pull request for creating a new integration package. labels Aug 5, 2022
@elasticmachine
Copy link

elasticmachine commented Aug 5, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Aug 5, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-30T17:22:03.628+0000

  • Duration: 17 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 5, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 2.564
Classes 100.0% (3/3) 💚 2.564
Methods 100.0% (43/43) 💚 9.946
Lines 95.42% (1500/1572) 👍 3.891
Conditionals 100.0% (0/0) 💚

@vinit-chauhan vinit-chauhan self-assigned this Aug 8, 2022
efd6
efd6 reviewed Aug 17, 2022
View reviewed changes
@vinit-chauhan
Copy link
Contributor Author

vinit-chauhan commented Sep 13, 2022

/test

efd6
efd6 reviewed Sep 21, 2022
View reviewed changes
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

efd6
efd6 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@andrewkroh andrewkroh merged commit 0e230f6 into elastic:main Oct 4, 2022
@andrewkroh andrewkroh mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@vinit-chauhan vinit-chauhan

@efd6 efd6

Labels

enhancement New feature or request New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trend Micro Vision One

4 participants

@vinit-chauhan @elasticmachine @efd6 @andrewkroh